Re: [Qemu-devel] [PATCH for-3.2 v7 6/6] hw/riscv/virt: Connect a VirtIO net PCIe device

[Alistair Francis]

On Wed, Nov 21, 2018 at 11:12 AM Logan Gunthorpe <address@hidden> wrote:
>
>
>
> On 2018-11-21 11:34 a.m., Alistair Francis wrote:
> >> I don't understand what this patch actually accomplishes. It doesn't
> >> seem to affect my network devices when running QEMU. Can you provide a
> >> commit message explaining this?
> >
> > Could you connect a PCIe networking device without this commit? This
> > is what the other architectures all do as well.
>
> Yes, actually.
>
> Other architectures doing something is never a sufficient justification
> to make a change. I'm also not sure how virtio relates to this patch...
>
> I'd say unless you know you're fixing something specific and can
> describe it, you should drop this patch.

It is required for networking for PCIe devices. What PCIe device works
for you without this patch? Can you tell me your command line
arguments.

Alistair

>
> Logan