[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-3.2 v2 01/30] fixup! net: do not depend o
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-3.2 v2 01/30] fixup! net: do not depend on slirp internals |
Date: |
Wed, 21 Nov 2018 23:10:35 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:18 +0400, a ecrit:
> Somehow, I broke the build and failed to detect it. Please squash!
> +#include "qemu/osdep.h"
> +
> +typedef uint32_t tcp_seq;
I preferred to just use uint32_t instead of tcp_seq in the couple of
places where this showed up.
> /*
> * Structure of an internet header, naked of options.
> @@ -50,6 +53,29 @@ struct ip {
> struct in_addr ip_src, ip_dst; /* source and dest address */
> } QEMU_PACKED;
>
> +/*
> + * TCP header.
> + * Per RFC 793, September, 1981.
> + */
> +#define tcphdr slirp_tcphdr
> +struct tcphdr {
> + uint16_t th_sport; /* source port */
> + uint16_t th_dport; /* destination port */
> + tcp_seq th_seq; /* sequence number */
> + tcp_seq th_ack; /* acknowledgement number */
> +#ifdef HOST_WORDS_BIGENDIAN
> + uint8_t th_off:4, /* data offset */
> + th_x2:4; /* (unused) */
> +#else
> + uint8_t th_x2:4, /* (unused) */
> + th_off:4; /* data offset */
> +#endif
> + uint8_t th_flags;
> + uint16_t th_win; /* window */
> + uint16_t th_sum; /* checksum */
> + uint16_t th_urp; /* urgent pointer */
> +};
> +
We already have struct tcp_hdr, in include/net/eth.h, so I used that
instead.
Too bad I have worked on that just a few minutes ago :)
Samuel
- [Qemu-devel] [PATCH v2 for-3.2 v2 00/30] slirp: make it again a standalone project, Marc-André Lureau, 2018/11/21
- [Qemu-devel] [PATCH v2 for-3.2 v2 01/30] fixup! net: do not depend on slirp internals, Marc-André Lureau, 2018/11/21
- Re: [Qemu-devel] [PATCH v2 for-3.2 v2 01/30] fixup! net: do not depend on slirp internals,
Samuel Thibault <=
- [Qemu-devel] [PATCH v2 for-3.2 v2 02/30] slirp: drop <Vista compatibility, Marc-André Lureau, 2018/11/21
- [Qemu-devel] [PATCH v2 for-3.2 v2 03/30] glib-compat: add g_spawn_async_with_fds() fallback, Marc-André Lureau, 2018/11/21
- [Qemu-devel] [PATCH v2 for-3.2 v2 04/30] slirp: simplify fork_exec(), Marc-André Lureau, 2018/11/21
- [Qemu-devel] [PATCH v2 for-3.2 v2 05/30] slirp: rename exec_list, Marc-André Lureau, 2018/11/21