Re: [Qemu-devel] [PATCH 0/5] tcg: Make bswap support in qemu_ld/st optional

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH 0/5] tcg: Make bswap support in qemu_ld/st optional

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6336156 tcg/arm: Set TCG_TARGET_HAS_MEMORY_BSWAP to false
8b6c77b tcg/aarch64: Set TCG_TARGET_HAS_MEMORY_BSWAP to false
97936ce tcg/i386: Set TCG_TARGET_HAS_MEMORY_BSWAP with have_movbe
b6d6faf tcg/optimize: Optimize bswap
6a671c7 tcg: Add TCG_TARGET_HAS_MEMORY_BSWAP

=== OUTPUT BEGIN ===
Checking PATCH 1/5: tcg: Add TCG_TARGET_HAS_MEMORY_BSWAP...
Checking PATCH 2/5: tcg/optimize: Optimize bswap...
ERROR: spaces required around that ':' (ctx:VxE)
#21: FILE: tcg/optimize.c:356:
+    CASE_OP_32_64(bswap16):
                           ^

ERROR: spaces required around that ':' (ctx:VxE)
#24: FILE: tcg/optimize.c:359:
+    CASE_OP_32_64(bswap32):
                           ^

ERROR: spaces required around that ':' (ctx:VxE)
#37: FILE: tcg/optimize.c:1117:
+        CASE_OP_32_64(bswap16):
                               ^

ERROR: spaces required around that ':' (ctx:VxE)
#38: FILE: tcg/optimize.c:1118:
+        CASE_OP_32_64(bswap32):
                               ^

total: 4 errors, 0 warnings, 24 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/5: tcg/i386: Set TCG_TARGET_HAS_MEMORY_BSWAP with have_movbe...
Checking PATCH 4/5: tcg/aarch64: Set TCG_TARGET_HAS_MEMORY_BSWAP to false...
Checking PATCH 5/5: tcg/arm: Set TCG_TARGET_HAS_MEMORY_BSWAP to false...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden