Re: [Qemu-devel] [PULL 00/13] Block layer patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PULL 00/13] Block layer patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e0ba295 iotests: Enhance 223 to cover multiple bitmap granularities
8f69d38 nvme: fix bug with PCI IRQ pins on teardown
34506f4 Revert "nvme: fix oob access issue(CVE-2018-16847)"
f9e29f0 nvme: fix out-of-bounds access to the CMB
5b2b7aa nvme: call blk_drain in NVMe reset code to avoid lockups
40ede8d iotests: fix nbd test 233 to work correctly with raw images
81f0a87 block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()
9d1d446 scsi-disk: Fix crash if underlying host file or disk returns error
114cf31 qemu-img: Fix leak
d1fac5e qemu-img: Fix typo
1e187df iotests: Skip 233 if certtool not installed
fdf543f iotests: Replace assertEquals() with assertEqual()
3b508f4 iotests: Replace time.clock() with Timeout

=== OUTPUT BEGIN ===
Checking PATCH 1/13: iotests: Replace time.clock() with Timeout...
Checking PATCH 2/13: iotests: Replace assertEquals() with assertEqual()...
Checking PATCH 3/13: iotests: Skip 233 if certtool not installed...
Checking PATCH 4/13: qemu-img: Fix typo...
Checking PATCH 5/13: qemu-img: Fix leak...
Checking PATCH 6/13: scsi-disk: Fix crash if underlying host file or disk 
returns error...
Checking PATCH 7/13: block: Fix update of BDRV_O_AUTO_RDONLY in 
update_flags_from_options()...
Checking PATCH 8/13: iotests: fix nbd test 233 to work correctly with raw 
images...
Checking PATCH 9/13: nvme: call blk_drain in NVMe reset code to avoid lockups...
Checking PATCH 10/13: nvme: fix out-of-bounds access to the CMB...
ERROR: space required after that ',' (ctx:VxV)
#107: FILE: tests/nvme-test.c:53:
+    pdev = qpci_device_find(qs->pcibus, QPCI_DEVFN(4,0));
                                                     ^

total: 1 errors, 0 warnings, 99 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 11/13: Revert "nvme: fix oob access issue(CVE-2018-16847)"...
Checking PATCH 12/13: nvme: fix bug with PCI IRQ pins on teardown...
Checking PATCH 13/13: iotests: Enhance 223 to cover multiple bitmap 
granularities...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden