[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue |
Date: |
Fri, 23 Nov 2018 19:17:34 -0500 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Thu, Nov 22, 2018 at 15:20:25 +0800, address@hidden wrote:
> +static uint64_t get_free_request_bitmap(Threads *threads, ThreadLocal
> *thread)
> +{
> + uint64_t request_fill_bitmap, request_done_bitmap, result_bitmap;
> +
> + request_fill_bitmap = atomic_rcu_read(&thread->request_fill_bitmap);
> + request_done_bitmap = atomic_rcu_read(&thread->request_done_bitmap);
> + bitmap_xor(&result_bitmap, &request_fill_bitmap, &request_done_bitmap,
> + threads->thread_requests_nr);
This is not wrong, but it's a big ugly. Instead, I would:
- Introduce bitmap_xor_atomic in a previous patch
- Use bitmap_xor_atomic here, getting rid of the rcu reads
Thanks,
Emilio
- Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue, (continued)
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue, Emilio G. Cota, 2018/11/23
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue,
Emilio G. Cota <=
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue, Christophe de Dinechin, 2018/11/27
[Qemu-devel] [PATCH v3 3/5] migration: use threaded workqueue for compression, guangrong . xiao, 2018/11/22