[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 23/24] hw/pvrdma: Do not clean resources on s
From: |
Yuval Shaia |
Subject: |
Re: [Qemu-devel] [PATCH v5 23/24] hw/pvrdma: Do not clean resources on shutdown |
Date: |
Sun, 25 Nov 2018 09:30:30 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Nov 22, 2018 at 02:14:01PM +0200, Yuval Shaia wrote:
> All resources are already cleaned at rm_fini phase.
Please ignore this patch, i will squash it to patch #5.
>
> Signed-off-by: Yuval Shaia <address@hidden>
> ---
> hw/rdma/rdma_backend.c | 21 +--------------------
> 1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
> index 6a1e39d4c0..8ab25e94b1 100644
> --- a/hw/rdma/rdma_backend.c
> +++ b/hw/rdma/rdma_backend.c
> @@ -1075,28 +1075,9 @@ static int mad_init(RdmaBackendDev *backend_dev,
> CharBackend *mad_chr_be)
>
> static void mad_stop(RdmaBackendDev *backend_dev)
> {
> - QObject *o_ctx_id;
> - unsigned long cqe_ctx_id;
> - BackendCtx *bctx;
> -
> - pr_dbg("Closing MAD\n");
> + pr_dbg("Stopping MAD\n");
>
> disable_rdmacm_mux_async(backend_dev);
> -
> - /* Clear MAD buffers list */
> - qemu_mutex_lock(&backend_dev->recv_mads_list.lock);
> - do {
> - o_ctx_id = qlist_pop(backend_dev->recv_mads_list.list);
> - if (o_ctx_id) {
> - cqe_ctx_id = qnum_get_uint(qobject_to(QNum, o_ctx_id));
> - bctx = rdma_rm_get_cqe_ctx(backend_dev->rdma_dev_res,
> cqe_ctx_id);
> - if (bctx) {
> - rdma_rm_dealloc_cqe_ctx(backend_dev->rdma_dev_res,
> cqe_ctx_id);
> - g_free(bctx);
> - }
> - }
> - } while (o_ctx_id);
> - qemu_mutex_unlock(&backend_dev->recv_mads_list.lock);
> }
>
> static void mad_fini(RdmaBackendDev *backend_dev)
> --
> 2.17.2
>
- [Qemu-devel] [PATCH v5 00/24] Add support for RDMA MAD, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 22/24] hw/rdma: Do not call rdma_backend_del_gid on an empty gid, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 21/24] hw/rdma: Do not use bitmap_zero_extend to free bitmap, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 19/24] vl: Introduce shutdown_notifiers, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 20/24] hw/pvrdma: Clean device's resource when system is shutdown, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 13/24] hw/pvrdma: Make sure PCI function 0 is vmxnet3, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 16/24] hw/pvrdma: Fill all CQE fields, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 23/24] hw/pvrdma: Do not clean resources on shutdown, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 15/24] hw/pvrdma: Make device state depend on Ethernet function state, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 24/24] docs: Update pvrdma device documentation, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 18/24] hw/rdma: Remove unneeded code that handles more that one port, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 17/24] hw/pvrdma: Fill error code in command's response, Yuval Shaia, 2018/11/22
- [Qemu-devel] [PATCH v5 06/24] hw/pvrdma: Make function reset_device return void, Yuval Shaia, 2018/11/22