[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-3.2 03/11] libvhost-user: exit by default on VHO
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH for-3.2 03/11] libvhost-user: exit by default on VHOST_USER_NONE |
Date: |
Mon, 26 Nov 2018 16:42:42 +0400 |
Since commit 2566378d6d13bf4d28c7770bdbda5f7682594bbe, libvhost-user
no longer panics on disconnect (rc == 0), and instead silently ignores
an invalid VHOST_USER_NONE message.
Without extra work from the API user, this will simply busy-loop on
HUP events. The obvious thing to do is to exit(0) instead, while
additional or different work can be done by overriding
iface->process_msg().
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Jens Freimann <address@hidden>
---
contrib/libvhost-user/libvhost-user.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/libvhost-user/libvhost-user.c
b/contrib/libvhost-user/libvhost-user.c
index a6b46cdc03..41470daf57 100644
--- a/contrib/libvhost-user/libvhost-user.c
+++ b/contrib/libvhost-user/libvhost-user.c
@@ -1285,7 +1285,8 @@ vu_process_message(VuDev *dev, VhostUserMsg *vmsg)
case VHOST_USER_SET_CONFIG:
return vu_set_config(dev, vmsg);
case VHOST_USER_NONE:
- break;
+ /* if you need processing before exit, override iface->process_msg */
+ exit(0);
case VHOST_USER_POSTCOPY_ADVISE:
return vu_set_postcopy_advise(dev, vmsg);
case VHOST_USER_POSTCOPY_LISTEN:
--
2.20.0.rc1
- [Qemu-devel] [PATCH for-3.2 00/11] vhost-user-backend & vhost-user-input, Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 01/11] vhost-user: define conventions for vhost-user backends, Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 02/11] vhost-user: simplify vhost_user_init/vhost_user_cleanup, Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 03/11] libvhost-user: exit by default on VHOST_USER_NONE,
Marc-André Lureau <=
- [Qemu-devel] [PATCH for-3.2 04/11] vhost-user: wrap some read/write with retry handling, Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 05/11] Add vhost-user-backend, Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 06/11] vhost-user: split vhost_user_read(), Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 07/11] vhost-user: add vhost_user_input_get_config(), Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 08/11] libvhost-user-glib: export vug_source_new(), Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 09/11] libvhost-user: add vu_queue_unpop(), Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 10/11] Add vhost-user-input-pci, Marc-André Lureau, 2018/11/26
- [Qemu-devel] [PATCH for-3.2 11/11] contrib: add vhost-user-input, Marc-André Lureau, 2018/11/26