[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.2 v4 10/28] qom: make interface types abst
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH for-3.2 v4 10/28] qom: make interface types abstract |
Date: |
Tue, 27 Nov 2018 17:55:02 +0400 |
On Tue, Nov 27, 2018 at 5:42 PM Eduardo Habkost <address@hidden> wrote:
>
> On Tue, Nov 27, 2018 at 01:27:43PM +0400, Marc-André Lureau wrote:
> > Interfaces don't have instance, let's make the interface type really
> > abstract to avoid confusion.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > Reviewed-by: Igor Mammedov <address@hidden>
>
> Reviewed-by: Eduardo Habkost <address@hidden>
>
> What about updating the documentation at qom/object.h with
> examples?
I don't like code example in documentation, they tend to bit rot
(hint: rustdoc :). Instead, we can point out
tests/check-qom-interface.c?
>
> --
> Eduardo
- [Qemu-devel] [PATCH for-3.2 v4 03/28] target/xtensa: xtfpga: provide default memory sizes, (continued)
- [Qemu-devel] [PATCH for-3.2 v4 03/28] target/xtensa: xtfpga: provide default memory sizes, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 04/28] MAINTAINERS: add missing xtensa patterns, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 05/28] 9p: fix QEMU crash when renaming files, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 06/28] MAINTAINERS: Assign some more files in the hw/arm/ directory, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 07/28] MAINTAINERS: Add an ARM SMMU section, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 09/28] tests: qdev_prop_check_globals() doesn't return "all_used", Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 08/28] net: cadence_gem: Remove incorrect assert(), Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 10/28] qom: make interface types abstract, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 11/28] qom: make user_creatable_complete() specific to UserCreatable, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 12/28] accel: register global_props like machine globals, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 13/28] qdev: move qdev_prop_register_global_list() to tests, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 14/28] qom: remove unimplemented class_finalize, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 15/28] hw: apply accel compat properties without touching globals, Marc-André Lureau, 2018/11/27