[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 00/13] hardfloat
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v6 00/13] hardfloat |
Date: |
Tue, 27 Nov 2018 12:52:58 -0500 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Tue, Nov 27, 2018 at 09:24:21 -0800, address@hidden wrote:
> /tmp/qemu-test/src/fpu/softfloat.c: In function 'f32_is_inf':
> /tmp/qemu-test/src/fpu/softfloat.c:325:16: error: implicit declaration of
> function 'isinff' [-Werror=implicit-function-declaration]
> return isinff(a.h);
> ^~~~~~
> /tmp/qemu-test/src/fpu/softfloat.c:325:16: error: incompatible implicit
> declaration of built-in function 'isinff' [-Werror]
> cc1: all warnings being treated as errors
> /tmp/qemu-test/src/fpu/softfloat.c: In function 'f32_is_inf':
> /tmp/qemu-test/src/fpu/softfloat.c:325:16: error: implicit declaration of
> function 'isinff' [-Werror=implicit-function-declaration]
> return isinff(a.h);
> ^~~~~~
> /tmp/qemu-test/src/fpu/softfloat.c:325:16: error: incompatible implicit
> declaration of built-in function 'isinff' [-Werror]
> cc1: all warnings being treated as errors
> make[1]: *** [/tmp/qemu-test/src/rules.mak:69: fpu/softfloat.o] Error 1
> make[1]: *** [/tmp/qemu-test/src/rules.mak:69: fpu/softfloat.o] Error 1
This is the offender:
+static inline bool f32_is_inf(union_float32 a)
+{
+ if (QEMU_HARDFLOAT_USE_ISINF) {
+ return isinff(a.h);
+ }
+ return float32_is_infinity(a.s);
+}
I've fixed up the branch on github to use isinf here instead
of isinff.
Emilio
- [Qemu-devel] [PATCH v6 12/13] hardfloat: implement float32/64 square root, (continued)
- [Qemu-devel] [PATCH v6 12/13] hardfloat: implement float32/64 square root, Emilio G. Cota, 2018/11/24
- [Qemu-devel] [PATCH v6 10/13] hardfloat: implement float32/64 division, Emilio G. Cota, 2018/11/24
- [Qemu-devel] [PATCH v6 06/13] tests/fp: add fp-bench, Emilio G. Cota, 2018/11/24
- [Qemu-devel] [PATCH v6 09/13] hardfloat: implement float32/64 multiplication, Emilio G. Cota, 2018/11/24
- [Qemu-devel] [PATCH v6 08/13] hardfloat: implement float32/64 addition and subtraction, Emilio G. Cota, 2018/11/24
- [Qemu-devel] [PATCH v6 07/13] fpu: introduce hardfloat, Emilio G. Cota, 2018/11/24
- [Qemu-devel] [PATCH v6 13/13] hardfloat: implement float32/64 comparison, Emilio G. Cota, 2018/11/24
- Re: [Qemu-devel] [PATCH v6 00/13] hardfloat, no-reply, 2018/11/27
- Re: [Qemu-devel] [PATCH v6 00/13] hardfloat,
Emilio G. Cota <=
- Re: [Qemu-devel] [PATCH v6 00/13] hardfloat, no-reply, 2018/11/27