[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check
From: |
Roman Kagan |
Subject: |
Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check |
Date: |
Tue, 27 Nov 2018 19:31:32 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Nov 27, 2018 at 07:50:54PM +0100, Paolo Bonzini wrote:
> On 23/11/18 10:01, Roman Kagan wrote:
> > elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be
> > set anywhere.
> >
> > The original intent was presumably to skip building it on Windows, so
> > check for "$mingw32" = "no" instead.
> >
> > Signed-off-by: Roman Kagan <address@hidden>
> > ---
> > configure | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 0a3c6a72c3..fc6ce0065d 100755
> > --- a/configure
> > +++ b/configure
> > @@ -5722,7 +5722,7 @@ if test "$want_tools" = "yes" ; then
> > if [ "$ivshmem" = "yes" ]; then
> > tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools"
> > fi
> > - if [ "$posix" = "yes" ] && [ "$curl" = "yes" ]; then
> > + if [ "$mingw32" = "no" ] && [ "$curl" = "yes" ]; then
> > tools="elf2dmp $tools"
> > fi
> > fi
> >
>
> Unfortunately this shows that elf2dmp is not portable to 32-bit systems,
> nor to non-Linux. Can this be fixed?
I'm sure it can, but not in time for 3.2. I'd rather drop this patch
for now and leave the tool disabled in 3.2.
[ FWIW the format specifier mismatches were addressed by Viktor's
patchset of some three weeks ago, "[PATCH 0/2] contrib/elf2dmp: elf2dmp
for Windows hosts", but it hasn't made it yet. ]
/me is wondering why patchew didn't scream at me for breaking 32-bit
builds. In the meantime I'll be setting up docker for testing 32-bit
builds locally.
Roman.