[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/16] virtio: split vhost vsock bits from vi
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/16] virtio: split vhost vsock bits from virtio-pci |
Date: |
Thu, 29 Nov 2018 07:30:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-11-26 20:59, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
>
> ---
>
> Updated copyright info
> Also split virtio-pci.h bits
> ---
> hw/virtio/Makefile.objs | 2 +-
> hw/virtio/vhost-vsock-pci.c | 82 +++++++++++++++++++++++++++++++++++++
> hw/virtio/virtio-pci.c | 51 -----------------------
> hw/virtio/virtio-pci.h | 18 --------
> 4 files changed, 83 insertions(+), 70 deletions(-)
> create mode 100644 hw/virtio/vhost-vsock-pci.c
>
> diff --git a/hw/virtio/Makefile.objs b/hw/virtio/Makefile.objs
> index 1b2799cfd8..4fbf7de84b 100644
> --- a/hw/virtio/Makefile.objs
> +++ b/hw/virtio/Makefile.objs
> @@ -10,7 +10,7 @@ obj-$(CONFIG_VIRTIO_CRYPTO) += virtio-crypto.o
> obj-$(call land,$(CONFIG_VIRTIO_CRYPTO),$(CONFIG_VIRTIO_PCI)) +=
> virtio-crypto-pci.o
>
> obj-$(CONFIG_LINUX) += vhost.o vhost-backend.o vhost-user.o
> -obj-$(CONFIG_VHOST_VSOCK) += vhost-vsock.o
> +obj-$(CONFIG_VHOST_VSOCK) += vhost-vsock.o vhost-vsock-pci.o
Please change this into:
obj-$(call land,$(CONFIG_VHOST_VSOCK),$(CONFIG_VIRTIO_PCI)) += vhost-vsock-pci.o
Rationale: There could be targets that don't use virtio-pci (but virtio-mmio or
virtio-ccw), and without this, the PCI devices are suddenly included while they
were not included before.
Same change in the other patches of this series, too, please.
Thomas
- [Qemu-devel] [PATCH v2 00/16] Virtio devices split from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 02/16] virtio: split virtio input host bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 03/16] virtio: split virtio input bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 06/16] virtio: split virtio 9p bits from virtio-pci, Juan Quintela, 2018/11/26