[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server require
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5 |
|
Date: |
Thu, 29 Nov 2018 12:22:51 +0400 |
On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann <address@hidden> wrote:
>
> On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote:
> > Looking at chardev/spice.c code, I realize compilation was broken for
> > a while with spice-server < 0.12.3. Let's bump required version
> > to 0.12.5, released May 19 2014, instead of adding more #ifdef.
>
> Oh, you did the 0.12.5 patch already. Scratch my other reply then.
>
> > - if $pkg_config --atleast-version=0.12.0 spice-server && \
> > + if $pkg_config --atleast-version=0.12.5 spice-server && \
> > $pkg_config --atleast-version=0.12.3 spice-protocol && \
>
> I think we should adjust spice-protocol too to whatever 0.12.5 requires
> to build.
>
Why not leave that responsibility to pkg-config, and only require in
qemu what is required there?