Re: [Qemu-devel] [qemu-web PATCH v2] Document how to test the site with jekyll locally

[Daniel P . Berrangé]

On Thu, Nov 29, 2018 at 07:34:56AM -0600, Eric Blake wrote:
> On 11/29/18 4:46 AM, Daniel P. Berrangé wrote:
> > Add a README file that tells people this is a jekyll based static
> > website, and shows people how to run jekyll for testing purposes.
> > 
> > Tested-by: Eric Blake <address@hidden>
> > Signed-off-by: Daniel P. Berrangé <address@hidden>
> > ---
> >   .gitignore  |  2 ++
> >   README      | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >   _config.yml |  2 ++
> >   3 files changed, 59 insertions(+)
> >   create mode 100644 README
> 
> > +Testing locally with Jekyll
> > +---------------------------
> > +
> > +When adding/changing content on this site, it is possible to run a
> > +local Jekyll service to test the result.
> > +
> > +QEMU requires a specific version of Jekyll (listedin Gemfile) which may
> 
> s/listedin/listed in/
> 
> > +++ b/_config.yml
> > @@ -37,3 +37,5 @@ gems:
> >   exclude:
> >     - Gemfile
> >     - Gemfile.lock
> > +  - vendor/
> > +  - README
> 
> Should .gitignore be in this list?  But that's pre-existing.

AFAICT, it excludes all dotfiles by default

> 
> With the typo fix,
> Reviewed-by: Eric Blake <address@hidden>
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|