Re: [Qemu-devel] [PATCH] pc:piix4: Update smbus I/O space after a migration

[Corey Minyard]

On 11/26/18 12:28 PM, address@hidden wrote:
> From: Corey Minyard <address@hidden>
>
> Otherwise it won't be set up correctly and won't work after
> miigration.

Any opinions on this?  I think this would be good for 3.1. Without
this when a migration occurs on piix4 the SMBus address space
appears in the wrong place.  I'm not sure how bad that is, but
SMBus certainly ceases to work.

-corey


> Signed-off-by: Corey Minyard <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> ---
>   hw/acpi/piix4.c | 1 +
>   1 file changed, 1 insertion(+)
>
> A rather obvious fix, in hindsight :).
>
> diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
> index e330f24c71..2f4dd03b83 100644
> --- a/hw/acpi/piix4.c
> +++ b/hw/acpi/piix4.c
> @@ -173,6 +173,7 @@ static int vmstate_acpi_post_load(void *opaque, int 
> version_id)
>       PIIX4PMState *s = opaque;
>   
>       pm_io_space_update(s);
> +    smbus_io_space_update(s);
>       return 0;
>   }
>