[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] util: vfio-helpers: use ARRAY_SIZE in qemu_vfio
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH] util: vfio-helpers: use ARRAY_SIZE in qemu_vfio_init_pci() |
Date: |
Fri, 30 Nov 2018 13:58:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 30/11/2018 13:01, Philippe Mathieu-Daudé wrote:
> On 30/11/18 10:53, Li Qiang wrote:
>> Cc: address@hidden
>>
>> Signed-off-by: Li Qiang <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
>> ---
>> util/vfio-helpers.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c
>> index cccc9cd42e..342d4a2285 100644
>> --- a/util/vfio-helpers.c
>> +++ b/util/vfio-helpers.c
>> @@ -348,7 +348,7 @@ static int qemu_vfio_init_pci(QEMUVFIOState *s, const
>> char *device,
>> goto fail;
>> }
>>
>> - for (i = 0; i < 6; i++) {
>> + for (i = 0; i < ARRAY_SIZE(s->bar_region_info); i++) {
>> ret = qemu_vfio_pci_init_bar(s, i, errp);
>> if (ret) {
>> goto fail;
>>
I'm wondering if adding a #define to define the size of the array and
then using it with the for() loop wouldn't be better?
Laurent