[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/16] tcg/mips: Remove retranslation code
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/16] tcg/mips: Remove retranslation code |
Date: |
Mon, 03 Dec 2018 10:39:26 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1.90 |
Richard Henderson <address@hidden> writes:
> There is no longer a need for preserving branch offset operands,
> as we no longer re-translate.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> tcg/mips/tcg-target.inc.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c
> index cff525373b..e21cb1ae28 100644
> --- a/tcg/mips/tcg-target.inc.c
> +++ b/tcg/mips/tcg-target.inc.c
> @@ -483,12 +483,7 @@ static inline void tcg_out_opc_bf64(TCGContext *s,
> MIPSInsn opc, MIPSInsn opm,
> static inline void tcg_out_opc_br(TCGContext *s, MIPSInsn opc,
> TCGReg rt, TCGReg rs)
> {
> - /* We pay attention here to not modify the branch target by reading
> - the existing value and using it again. This ensure that caches and
> - memory are kept coherent during retranslation. */
> - uint16_t offset = (uint16_t)*s->code_ptr;
> -
> - tcg_out_opc_imm(s, opc, rt, rs, offset);
> + tcg_out_opc_imm(s, opc, rt, rs, 0);
> }
>
> /*
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 10/16] tcg/mips: Remove retranslation code,
Alex Bennée <=