[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 13/16] tcg/aarch64: Return false on failure f
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3 13/16] tcg/aarch64: Return false on failure from patch_reloc |
Date: |
Mon, 3 Dec 2018 07:23:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/3/18 4:43 AM, Alex Bennée wrote:
>> case R_AARCH64_CONDBR19:
>> - reloc_pc19(code_ptr, (tcg_insn_unit *)value);
>> - break;
>> + return reloc_pc19(code_ptr, (tcg_insn_unit *)value);
>> default:
>> tcg_abort();
>> }
>> - return true;
>
> nit: the default leg could return false for the same effect
Would it be clearer changed to g_assert_not_reached()?
Because I'm not intending "unknown relocation" to have
the same effect as "out of range relocation".
r~