[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 for 3.1 0/4] Fix possible OOB during queuing
Re: [Qemu-devel] [PATCH V4 for 3.1 0/4] Fix possible OOB during queuing packets
Mon, 3 Dec 2018 16:18:57 +0000
On Mon, 3 Dec 2018 at 10:06, Jason Wang <address@hidden> wrote:
> This series tries to fix a possible OOB during queueing packets
> through qemu_net_queue_append_iov(). This could happen when it tries
> to queue a packet whose size is larger than INT_MAX which may lead
> integer overflow. We've fixed similar issue in the past during
> qemu_net_queue_deliver_iov() by ignoring large packets there. Let's
> just move the check earlier to qemu_sendv_packet_async() and reduce
> the limitation to NET_BUFSIZE. A simple qtest were also added this.
> Please review.
I did a test build and run, and the new test generates warning
messages during "make check":
qemu-system-ppc64: warning: hub 0 is not connected to host network
(similarly for /i386/ and /x86_64/).
- Re: [Qemu-devel] [PATCH V4 for 3.1 1/4] net: drop too large packet early, (continued)