Re: [Qemu-devel] [PULL 0/3] Merge tpm 2018/12/04 v1

[Peter Maydell]

On Tue, 4 Dec 2018 at 15:43, Peter Maydell <address@hidden> wrote:
>
> On Tue, 4 Dec 2018 at 15:34, Stefan Berger <address@hidden> wrote:
> >
> > This series of patches removes an unnecessary parameter from tpm_tis_abort()
> > and adds a locality range check (using assert()) to tpm_tis_prep_abort() and
> > tpm_tis_request_completed().
> >
> >    Stefan
> >
> > The following changes since commit 83ea23cd207a03c5736be0231acbf7f8b05dbf52:
> >
> >   i386: hvf: Fix overrun of _decode_tbl1 (2018-12-03 15:09:55 +0000)
> >
> > are available in the Git repository at:
> >
> >   git://github.com/stefanberger/qemu-tpm.git tags/pull-tpm-2018-12-04-1
> >
> > for you to fetch changes up to a639f96111eadb3b8e3021fd3f27e2948ad1c640:
> >
> >   tpm: Make sure the locality received from backend is valid (2018-12-04 
> > 10:21:25 -0500)
>
> Hi -- can you provide a justification for why this is rc4 material,
> please? This wasn't on the list of "things that maybe or must go
> into rc4", and the commit messages and pull request cover letter
> don't suggest that there's anything particularly urgent here
> that couldn't wait for 4.0.

I looked through the patchset again, looked back at the history
of it on the mailing list, and got some second opinions on IRC
from Marc-André Lureau and Philippe Mathieu-Daudé. We don't think
this is 3.1 material at this point in the release process. So
I'm not going to apply it -- please resubmit as a pullreq for
4.0 once the tree reopens for development.

thanks
-- PMM