[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 5/7] util/mmap-alloc: Switch the RAM_SYNC fla
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 5/7] util/mmap-alloc: Switch the RAM_SYNC flags to OnOffAuto |
Date: |
Wed, 5 Dec 2018 09:49:05 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Nov 05, 2018 at 04:29:30PM +0800, Zhang Yi wrote:
> diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c
> index f411df7..fe9303f 100644
> --- a/util/mmap-alloc.c
> +++ b/util/mmap-alloc.c
> @@ -111,6 +111,10 @@ void *qemu_ram_mmap(int fd, size_t size, size_t align,
> uint32_t flags)
> assert(is_power_of_2(align));
> /* Always align to host page size */
> assert(align >= getpagesize());
> + if ((flags & RAM_SYNC_ON_OFF_AUTO_ON) &&
> + (!shared || !MAP_SYNC_FLAGS)) {
> + return MAP_FAILED;
> + }
Missing munmap(ptr, total)?
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v5 5/7] util/mmap-alloc: Switch the RAM_SYNC flags to OnOffAuto,
Stefan Hajnoczi <=