[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [for-4.0 PATCH v3 3/9] qapi: Define PCIe link speed and

From: Markus Armbruster
Subject: Re: [Qemu-devel] [for-4.0 PATCH v3 3/9] qapi: Define PCIe link speed and width properties
Date: Wed, 05 Dec 2018 17:21:41 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Auger Eric <address@hidden> writes:

> Hi Markus,
> On 12/5/18 3:16 PM, Markus Armbruster wrote:
>> Auger Eric <address@hidden> writes:
>>> nit: g_assert_not_reached() here and below.
>> In my opinion, g_assert_not_reached() & friends are an overly ornate
>> reinvention of an old and perfectly adequate wheel.
>> A long time ago for reasons since forgotten, the maintainers in charge
>> back then demanded abort() instead of assert(0).  Either is fine with
>> me.
>> I tolerate g_assert_not_reached() in files that already use g_assert().
>> This one doesn't.
>> In any case, I'd drop the comment.
> OK I did not know. In the past I was encouraged to use it.

Some maintainers like ornate ;)

> Thanks
> Eric
>> Note that I'm not this file's maintainer.
>> [...]

reply via email to

[Prev in Thread] Current Thread [Next in Thread]