[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB |
Date: |
Thu, 6 Dec 2018 00:37:34 +0400 |
Not all backends are able to switch gcontext. Those backends cannot
drive a OOB monitor (the monitor would then be blocking on main
thread).
For example, ringbuf, spice, or more esoteric input chardevs like
braille or MUX.
We currently forbid MUX because not all frontends are ready to run
outside main loop. Extend to add a context-switching feature check.
Signed-off-by: Marc-André Lureau <address@hidden>
---
monitor.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 79afe99079..25cf4223e8 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4562,9 +4562,11 @@ void monitor_init(Chardev *chr, int flags)
bool use_oob = flags & MONITOR_USE_OOB;
if (use_oob) {
- if (CHARDEV_IS_MUX(chr)) {
+ if (CHARDEV_IS_MUX(chr) ||
+ !qemu_chr_has_feature(chr, QEMU_CHAR_FEATURE_GCONTEXT)) {
error_report("Monitor out-of-band is not supported with "
- "MUX typed chardev backend");
+ "%s typed chardev backend",
+ object_get_typename(OBJECT(chr)));
exit(1);
}
if (use_readline) {
--
2.20.0.rc1
- [Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes, Marc-André Lureau, 2018/12/05
- [Qemu-devel] [PATCH for-4.0 v4 1/7] monitor: inline ambiguous helper functions, Marc-André Lureau, 2018/12/05
- [Qemu-devel] [PATCH for-4.0 v4 2/7] monitor: accept chardev input from iothread, Marc-André Lureau, 2018/12/05
- [Qemu-devel] [PATCH for-4.0 v4 3/7] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag, Marc-André Lureau, 2018/12/05
- [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB,
Marc-André Lureau <=
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
[Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context, Marc-André Lureau, 2018/12/05