[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 00/37] ppc: support for the XIVE interrupt co

From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v6 00/37] ppc: support for the XIVE interrupt controller (POWER9)
Date: Thu, 6 Dec 2018 17:24:00 +0800

> On Dec 6, 2018, at 14:14, Cédric Le Goater <address@hidden> wrote:
> Hello,
>> Your patch has style problems, please review.  If any of these errors
>> are false positives report them to the maintainer, see
>> Checking PATCH 25/37: spapr/xive: add state synchronization with KVM...
>> Checking PATCH 26/37: spapr/xive: introduce a VM state change handler...
>> ERROR: spaces required around that '*' (ctx:WxV)
>> #38: FILE: hw/intc/spapr_xive_kvm.c:341:
>> + static void kvmppc_xive_sync_all(sPAPRXive *xive, Error **errp)
>>                                             ^
>> total: 1 errors, 0 warnings, 135 lines checked
> This looks like a false positive.

Right. Without looking at the checkpatch code, I suspect this is due to 
sPAPRXive starts with a lower case letter which is not standard.


> C.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]