[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/71] vhost: restrict Linux dependency to kerne
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 03/71] vhost: restrict Linux dependency to kernel vhost |
Date: |
Thu, 6 Dec 2018 14:36:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-12-03 16:32, Paolo Bonzini wrote:
> vhost-user does not depend on Linux; it can run on any POSIX system. Restrict
> vhost-kernel to Linux in hw/virtio/vhost-backend.c, everything else can be
> compiled on all POSIX systems.
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> backends/Makefile.objs | 5 ++---
> default-configs/virtio.mak | 4 ++--
> hw/net/vhost_net.c | 2 +-
> hw/virtio/Makefile.objs | 5 +++--
> hw/virtio/vhost-backend.c | 11 +++++++++--
> 5 files changed, 17 insertions(+), 10 deletions(-)
[...]
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index fe6202a..2a300ee 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -193,7 +193,7 @@ struct vhost_net *vhost_net_init(VhostNetOptions *options)
> }
>
> /* Set sane init value. Override when guest acks. */
> -#ifdef CONFIG_VHOST_USER
> +#ifdef CONFIG_VHOST_NET_USER
Merge this hunk with the previous patch?
Apart from that nit:
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH for-4.0 00/71] qtest: qgraph driver framework, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 02/71] vhost-net-user: add stubs for when no virtio-net device is present, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 01/71] vhost-net: move stubs to a separate file, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 03/71] vhost: restrict Linux dependency to kernel vhost, Paolo Bonzini, 2018/12/03
- Re: [Qemu-devel] [PATCH 03/71] vhost: restrict Linux dependency to kernel vhost,
Thomas Huth <=
- [Qemu-devel] [PATCH 04/71] vhost-net: compile it on all targets that have virtio-net., Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 05/71] vhost-net: revamp configure logic, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 07/71] vhost-user-test: signal data_cond when s->rings changes, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 08/71] vhost-user: support cross-endian vnet headers, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 09/71] vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN, Paolo Bonzini, 2018/12/03