[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-4.0 1/5] tests/boot-serial: Get rid of globa

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-4.0 1/5] tests/boot-serial: Get rid of global_qtest variable
Date: Thu, 6 Dec 2018 13:56:37 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/6/18 1:34 PM, Thomas Huth wrote:
On 2018-12-06 19:42, Eric Blake wrote:
On 12/6/18 10:49 AM, Thomas Huth wrote:
The test does not use any of the functions that require global_qtest,
so we can simply get rid of this global variable here.

Signed-off-by: Thomas Huth <address@hidden>
   tests/boot-serial-test.c | 13 +++++++------
   1 file changed, 7 insertions(+), 6 deletions(-)

-    global_qtest = qtest_initf("%s %s -M %s,accel=tcg:kvm "
-                               "-chardev file,id=serial0,path=%s "
-                               "-no-shutdown -serial chardev:serial0
-                               codeparam, code ? codetmp : "",
-                               test->machine, serialtmp, test->extra);
+    qts = qtest_initf("%s %s -M %s,accel=tcg:kvm -no-shutdown "
+                      "-chardev file,id=serial0,path=%s "
+                      " -serial chardev:serial0 %s",

What happened to -no-shutdown?

Moved to the first line (since there was some more space there now).

Aha - serves me right for thinking you just reindented, rather than spotting that you also rearranged in order to reflow the breaks.

You still have a minor issue of a double space (one to end the -chardev fragment, another to start the -serial fragment); with that fixed,

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]