[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events
Date: Fri, 7 Dec 2018 10:46:27 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/7/18 10:37 AM, Laurent Vivier wrote:
On 07/12/2018 16:37, Philippe Mathieu-Daudé wrote:
On 12/7/18 2:17 PM, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier <address@hidden>

TIL about trace_event_get_state_backends(), I'll use it to clean other
hexdump traces, thanks :)

I've copied that from gdbstub.c where there is an hexdump() function
using it.

I'm going to send a v2 of this patch, because I think it is not needed
in this case to pass the function in the parameters.

Don't forget the 0/2 cover letter in that case (all series of >1 patch are easier to process with a cover letter, even if it is just 2 patches)

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]