[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context pr
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section" |
Date: |
Mon, 10 Dec 2018 13:25:17 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 10.12.2018 um 13:14 hat Denis Plotnikov geschrieben:
> >> @@ -491,9 +506,17 @@ int64_t aio_compute_timeout(AioContext *ctx);
> >> */
> >> static inline void aio_disable_external(AioContext *ctx)
> >> {
> >> + aio_context_acquire(ctx);
> >> atomic_inc(&ctx->external_disable_cnt);
> >> + aio_context_release(ctx);
> >> }
> >
> > This acquire/release pair looks rather useless?
>
> I'm not sure that I understand everything correctly...
> but can a thread (context) try to disable external in another context?
Yes, that can happen. For example, think of bdrv_drain_all().
Kevin
- [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section", Denis Plotnikov, 2018/12/05
- Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section", Kevin Wolf, 2018/12/07
- Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section", Denis Plotnikov, 2018/12/10
- Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section",
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section", Denis Plotnikov, 2018/12/11
- Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section", Kevin Wolf, 2018/12/12
- Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section", Denis Plotnikov, 2018/12/13
- Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section", Kevin Wolf, 2018/12/13
- Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section", Denis Plotnikov, 2018/12/14
- Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section", Denis Plotnikov, 2018/12/18