qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.


From: Laszlo Ersek
Subject: Re: [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h"
Date: Mon, 10 Dec 2018 16:00:33 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 12/07/18 17:51, Philippe Mathieu-Daudé wrote:
> All the consumers of "smbios_ipmi.h" are located in hw/smbios/.

I tried to verify this statement by grepping the tree for
"smbios_ipmi.h". There were zero hits. Please use the more precise
pathname "hw/smbios/ipmi.h". (I can't suggest just "ipmi.h", because
that isn't unique.)

With this update:

Reviewed-by: Laszlo Ersek <address@hidden>

Thanks,
Laszlo

> There is no need to have this include publicly exposed,
> reduce the visibility by moving it in hw/smbios/.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  hw/smbios/smbios.c                                  | 2 +-
>  include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h | 0
>  hw/smbios/smbios_type_38-stub.c                     | 2 +-
>  hw/smbios/smbios_type_38.c                          | 2 +-
>  4 files changed, 3 insertions(+), 3 deletions(-)
>  rename include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h (100%)
> 
> diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
> index 920939454e..30bd4731cf 100644
> --- a/hw/smbios/smbios.c
> +++ b/hw/smbios/smbios.c
> @@ -28,7 +28,7 @@
>  #include "hw/loader.h"
>  #include "exec/cpu-common.h"
>  #include "smbios_build.h"
> -#include "hw/smbios/ipmi.h"
> +#include "smbios_ipmi.h"
>  
>  /* legacy structures and constants for <= 2.0 machines */
>  struct smbios_header {
> diff --git a/include/hw/smbios/ipmi.h b/hw/smbios/smbios_ipmi.h
> similarity index 100%
> rename from include/hw/smbios/ipmi.h
> rename to hw/smbios/smbios_ipmi.h
> diff --git a/hw/smbios/smbios_type_38-stub.c b/hw/smbios/smbios_type_38-stub.c
> index 5b83c9b1f1..fc4516bc8a 100644
> --- a/hw/smbios/smbios_type_38-stub.c
> +++ b/hw/smbios/smbios_type_38-stub.c
> @@ -8,7 +8,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> -#include "hw/smbios/ipmi.h"
> +#include "smbios_ipmi.h"
>  
>  void smbios_build_type_38_table(void)
>  {
> diff --git a/hw/smbios/smbios_type_38.c b/hw/smbios/smbios_type_38.c
> index 56e8609c00..d84e87d608 100644
> --- a/hw/smbios/smbios_type_38.c
> +++ b/hw/smbios/smbios_type_38.c
> @@ -9,10 +9,10 @@
>  
>  #include "qemu/osdep.h"
>  #include "hw/ipmi/ipmi.h"
> -#include "hw/smbios/ipmi.h"
>  #include "hw/smbios/smbios.h"
>  #include "qemu/error-report.h"
>  #include "smbios_build.h"
> +#include "smbios_ipmi.h"
>  
>  /* SMBIOS type 38 - IPMI */
>  struct smbios_type_38 {
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]