[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.2 v5 00/19] Generalize machine compatibili
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH for-3.2 v5 00/19] Generalize machine compatibility properties |
Date: |
Mon, 10 Dec 2018 15:39:32 -0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Dec 10, 2018 at 06:31:59PM +0100, Igor Mammedov wrote:
> On Mon, 10 Dec 2018 15:07:18 -0200
> Eduardo Habkost <address@hidden> wrote:
>
> > On Tue, Dec 04, 2018 at 06:20:04PM +0400, Marc-André Lureau wrote:
> > [...]
> > > Marc-André Lureau (19):
> > > tests: qdev_prop_check_globals() doesn't return "all_used"
> > > qom: make interface types abstract
> > > qom: make user_creatable_complete() specific to UserCreatable
> > > accel: register global_props like machine globals
> > > qdev: move qdev_prop_register_global_list() to tests
> > > qom: remove unimplemented class_finalize
> >
> > Patches 1-6 (above) queued on machine-next. Thanks!
> let's drop patch 6 for now until we decide what to do with GPtrArray leaks
I appreciate your effort to make sure there are no memory
allocations that could make Valgrind complain, but I don't see
the point of keeping dead code that was never called in the tree.
Are the new GPtrArray allocations different from the g_malloc0()
calls in type_new() and type_initialize()? Doesn't Valgrind
complain about them today?
--
Eduardo
- Re: [Qemu-devel] [PATCH for-3.2 v5 14/19] qdev-props: call object_apply_global_props(), (continued)
- Re: [Qemu-devel] [PATCH for-3.2 v5 00/19] Generalize machine compatibility properties, Marc-André Lureau, 2018/12/04
- [Qemu-devel] [PATCH for-3.2 v5 15/19] qom: add object_class_get_class_data(), Marc-André Lureau, 2018/12/04
- [Qemu-devel] [PATCH for-3.2 v5 17/19] hw/i386: add pc-i440fx-4.0 & pc-q35-4.0, Marc-André Lureau, 2018/12/04
- [Qemu-devel] [PATCH for-3.2 v5 16/19] RFC: arm: replace instance_post_init(), Marc-André Lureau, 2018/12/04
- [Qemu-devel] [PATCH for-3.2 v5 18/19] hw/arm/virt: add virt-4.0 machine type, Marc-André Lureau, 2018/12/04
- [Qemu-devel] [PATCH for-3.2 v5 19/19] hostmem: use object id for memory region name with >= 4.0, Marc-André Lureau, 2018/12/04
- Re: [Qemu-devel] [PATCH for-3.2 v5 00/19] Generalize machine compatibility properties, Eduardo Habkost, 2018/12/10