[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [QEMU-devel][PATCH v2] aio-posix: Fix concurrent aio_po

From: Remy NOEL
Subject: Re: [Qemu-devel] [QEMU-devel][PATCH v2] aio-posix: Fix concurrent aio_poll/set_fd_handler.
Date: Tue, 11 Dec 2018 11:37:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2

On 12/10/18 8:05 PM, Stefan Hajnoczi wrote:

On Thu, Dec 06, 2018 at 11:14:23AM +0100, address@hidden wrote:
+        if (is_new) {
+            new_node->pfd.fd = fd;
+        } else {
+            deleted = aio_remove_fd_handler(ctx, node);
+            new_node->pfd = node->pfd;
Does this drop revents?  Imagine revents has bits set, then
aio_remove_fd_handler() will clear them and new_node->pfd = node->pfd is
too late to preserve them.

Indeed, i will invert those.

Thanks !

reply via email to

[Prev in Thread] Current Thread [Next in Thread]