[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing feature
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine |
Date: |
Tue, 11 Dec 2018 14:55:10 -0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Dec 11, 2018 at 02:40:33PM -0200, Wainer dos Santos Moschetta wrote:
[...]
> > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > > index f81d35e1f9..2502a3adda 100644
> > > --- a/target/i386/cpu.c
> > > +++ b/target/i386/cpu.c
> > > @@ -3615,19 +3615,29 @@ static void
> > > x86_cpu_class_check_missing_features(X86CPUClass *xcc,
> > > x86_cpu_filter_features(xc);
> > > + /* Uses an auxiliar dictionary to ensure the list of features has not
> > > + repeated name. */
> > > + QDict *unique_feats_dict = qdict_new();
> > Multiline comments are formatted this way:
> >
> > /*
> > * like
> > * this
> > */
> >
> > (See CODING_STYLE for details)
>
> scripts/checkpatch.pl did not catch it. Should it?
It should, we just need a volunteer who understands Perl to fix
that. :)
--
Eduardo