[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 4/6] target/ppc: switch FPR, VMX and VSX hel
Re: [Qemu-devel] [RFC PATCH 4/6] target/ppc: switch FPR, VMX and VSX helpers to access data directly from cpu_env
Tue, 11 Dec 2018 15:24:02 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1
On 12/11/18 1:21 PM, Mark Cave-Ayland wrote:
>> Note however, that there are other steps that you must add here before using
>> vector operations in the next patch:
>> (1a) The fpr and vsr arrays must be merged, since fpr[n] == vsrh[n].
>> If this isn't done, then you simply cannot apply one operation
>> to two disjoint memory blocks.
>> (1b) The vsr and avr arrays should be merged, since vsr[32+n] == avr[n].
>> This is simply tidiness, matching the layout to the architecture.
>> These steps will modify gdbstub.c, machine.c, and linux-user/.
> The reason I didn't touch the VSR arrays was because I was hoping that this
> could be
> done as a follow up later; my thought was that since I'd only introduced
> operations into the VMX instructions then currently no vector operations
> could be
> done across the 2 separate memory blocks?
True, until you convert the VSX insns you can delay this.
Though honestly I would consider doing both at once.
>> (2) The vsr array needs to be QEMU_ALIGN(16). See target/arm/cpu.h.
>> We assert that the host addresses are 16 byte aligned, so that we
>> can eventually use Altivec/VSX in tcg/ppc/.
> That's a good observation. Presumably being on Intel the unaligned accesses
> still work but just be slower? I've certainly seen the new vector ops being
> in the generated code.
Yes, currently I generate unaligned loads. It made sense when considering AVX2
and ARM SVE, since I do not increase the alignment requirements to 32-bytes
when using 256-bit vectors.
I do wonder if I should go back and generate aligned loads, just to raise
SIGBUS when one has forgotten the QEMU_ALIGN marker, as a portability aid.
- Re: [Qemu-devel] [RFC PATCH 1/6] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access, (continued)
- [Qemu-devel] [RFC PATCH 6/6] target/ppc: convert vaddu[b, h, w, d] and vsubu[b, h, w, d] over to use vector operations, Mark Cave-Ayland, 2018/12/07
- [Qemu-devel] [RFC PATCH 5/6] target/ppc: convert VMX logical instructions to use vector operations, Mark Cave-Ayland, 2018/12/07
- Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations, BALATON Zoltan, 2018/12/09