[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 04/11] monitor: check if chardev can switch gcontext

From: Markus Armbruster
Subject: [Qemu-devel] [PULL 04/11] monitor: check if chardev can switch gcontext for OOB
Date: Wed, 12 Dec 2018 11:11:38 +0100

From: Marc-André Lureau <address@hidden>

Not all backends are able to switch gcontext. Those backends cannot
drive a OOB monitor (the monitor would then be blocking on main

For example, ringbuf, spice, or more esoteric input chardevs like
braille or MUX.

We already forbid MUX because not all frontends are ready to run outside
main loop.  Replace that by a context-switching feature check.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
[Error condition simplified, commit message adjusted accordingly]
Signed-off-by: Markus Armbruster <address@hidden>
 monitor.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/monitor.c b/monitor.c
index 79afe99079..a1329d8a86 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4562,9 +4562,10 @@ void monitor_init(Chardev *chr, int flags)
     bool use_oob = flags & MONITOR_USE_OOB;
     if (use_oob) {
-        if (CHARDEV_IS_MUX(chr)) {
+        if (!qemu_chr_has_feature(chr, QEMU_CHAR_FEATURE_GCONTEXT)) {
             error_report("Monitor out-of-band is not supported with "
-                         "MUX typed chardev backend");
+                         "%s typed chardev backend",
+                         object_get_typename(OBJECT(chr)));
         if (use_readline) {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]