[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] Deprecate QMP `cpu-add`
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] Deprecate QMP `cpu-add` |
Date: |
Thu, 13 Dec 2018 07:38:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-10-30 13:35, Kashyap Chamarthy wrote:
> The intended functionality of QMP `cpu-add` is replaced with
> `device_add` (and `query-hotpluggable-cpus`). So let's deprecate
> `cpu-add`.
>
> A complete example of vCPU hotplug with the recommended way (using
> `device_add`) is provided as part of a seperate docs patch.
>
> Suggested-by: Eduardo Habkost <address@hidden
> Signed-off-by: Kashyap Chamarthy <address@hidden>
> ---
[...]
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 1b9c007f12..c86924ad9a 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi
> @@ -155,6 +155,11 @@ The ``query-cpus'' command is replaced by the
> ``query-cpus-fast'' command.
> The ``arch'' output member of the ``query-cpus-fast'' command is
> replaced by the ``target'' output member.
>
> address@hidden cpu-add (since 3.1)
Hi Kashyap,
could you please send a follow-up patch to change this into 4.0 now?
Please also provide a patch to add the HMP command to
qemu-deprecated.texi, too.
Thanks,
Thomas
- Re: [Qemu-devel] [PATCH v3 1/3] Deprecate QMP `cpu-add`,
Thomas Huth <=