[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 27/32] qapi: add #if conditions to generated code

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PULL 27/32] qapi: add #if conditions to generated code members
Date: Fri, 14 Dec 2018 07:06:56 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 12/13/18 12:43 PM, Markus Armbruster wrote:
>> From: Marc-André Lureau <address@hidden>
>> Wrap generated enum and struct members and their supporting code with
> Git ate the line because it started with #.  Not sure if you can sneak
> in a v2 pull request that puts something sane here...

v2 sent, and my .gitconfig now has

            cleanup = scissors

Let's see how I fare with that.


>> We do enum and struct in a single patch because union tag enum and the
>> associated variants tie them together, and dealing with that to split
>> the patch doesn't seem worthwhile.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]