[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v11 1/7] bitmap: fix bitmap_count_one

From: Wei Wang
Subject: Re: [Qemu-devel] [PATCH v11 1/7] bitmap: fix bitmap_count_one
Date: Fri, 14 Dec 2018 14:37:34 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 12/13/2018 10:28 PM, Dr. David Alan Gilbert wrote:
* Wei Wang (address@hidden) wrote:
BITMAP_LAST_WORD_MASK(nbits) returns 0xffffffff when "nbits=0", which
makes bitmap_count_one fail to handle the "nbits=0" case. It appears to be
preferred to remain BITMAP_LAST_WORD_MASK identical to the kernel
implementation that it is ported from.

So this patch fixes bitmap_count_one to handle the nbits=0 case.
OK; it's a little odd that it's only bitmap_count_one that's being fixed
for this case; but OK.

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

We could also help fix other callers outside this series.
(this one is put here as it helps this optimization feature avoid that issue).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]