[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

From: Wainer dos Santos Moschetta
Subject: Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block
Date: Fri, 14 Dec 2018 10:13:26 -0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 12/13/2018 04:01 PM, Peter Maydell wrote:
On Thu, 13 Dec 2018 at 17:57, Wainer dos Santos Moschetta
<address@hidden> wrote:
Eduardo Habkost pointed out a malformed block of comments on my
patch [1] that I had ran checkpatch.pl and no warn/error was
reported. Then I realized the script does not catch such as
case (or it had a bug).

It turns out that checkpatch.pl does not parse comment blocks (If I understood
its code correctly...). So I implemented a checker that warns about:
1. block doesn't begin on its own line.
   /* blah blah
    * and blah blah
I sent a patch to do this a little while back:

Self-NACK my patch in favor of that, which has additional checks (e.g. * alignment).

It didn't get applied because Paolo disagreed with having
our tools enforcing what our style guide says.

Personally I think we should just commit my patch, and then
we can stop having people manually pointing out where
submitters' patches don't match CODING_STYLE.

I am afraid that I can't give a firm option on this topic because it precedes my existence in this community, regardless I tend to agreed on Peter's reasoning.


- Wainer


-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]