[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [QEMU-devel][PATCH v3] aio-posix: Fix concurrent aio_po

From: Remy NOEL
Subject: Re: [Qemu-devel] [QEMU-devel][PATCH v3] aio-posix: Fix concurrent aio_poll/set_fd_handler.
Date: Wed, 19 Dec 2018 17:36:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2

On 12/18/18 3:14 PM, Stefan Hajnoczi wrote:

Please include a changelog in future patches.  For example:

  * Don't drop revents when a handler is modified [Stefan]

That way reviewers know what to look for and which issues you have
Sorry, wasn't sure i had to do this in single commit patches without cover letter.
Thanks!  The worst case I can now imagine is if an fd is handled twice
due to a concurrent aio_set_fd_handler() call, but spurious
->io_read()/->io_write() should not cause problems.

Concurrent aio_set_fd_handlers should not be possible (not on the same AioContext at least) since we lock ctx->list_lock.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]