[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/9] tests: apci: consolidate and cleanup ACPI t

From: Daniel P . Berrangé
Subject: Re: [Qemu-devel] [PATCH 0/9] tests: apci: consolidate and cleanup ACPI test code
Date: Wed, 19 Dec 2018 16:45:17 +0000
User-agent: Mutt/1.10.1 (2018-07-13)

On Wed, Dec 19, 2018 at 11:38:36AM -0500, Michael S. Tsirkin wrote:
> On Mon, Dec 10, 2018 at 07:10:06PM +0100, Igor Mammedov wrote:
> > While working on adding tests for virt/arm board (uefi/XSDT/64-bit table 
> > pointers),
> > I found it's rather difficult to deal with mixed ACPI testing code that 
> > we've
> > collected so far. So instead of just adding a pile of XSDT hacks on top, 
> > here
> > goes small refactoring series:
> >    * that removes dead code
> >    * replaces reading tables with a fetch per table everywhere instead of
> >      mix of field by field and whole table
> >    * consolidates the way tables are read (reduces code duplication)
> >    * test no longer depends on ACPI structures from QEMU (i.e. doesn't 
> > affected
> >      by mistakes there) 
> >    * fixiex FACS not beint compared against reference tables
> > Overall test is reduced on ~170LOC and hopefully it makes easier to add more
> > stuff on top.
> So this was posted outside the merge window - do you still want
> it merged? If yes pls repost.

Huh, QEMU development does not have merge windows. Subsystem maintainers
should review patch series at any time & queue it if it is acceptable.
The freeze process only applies to maintainers sending pull requests for
merge to git mater.  Contributors shouldn't be expected to resubmit
patches in this case.

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

reply via email to

[Prev in Thread] Current Thread [Next in Thread]