[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate th

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle
Date: Wed, 19 Dec 2018 11:29:16 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/19/18 6:14 AM, Fei Li wrote:

   28 files changed, 243 insertions(+), 101 deletions(-)

I recommend to split this patch.  First part adds the Error ** parameter
to qemu_thread_create(), passing &error_abort everywhere.  No functional
change.  Subsequent patches then improve on &error_abort.  This way,
each improvement patch can be cc'ed to just that part's maintainer(s).
Parts you don't want to touch you simply leave at &error_abort.  Makes
Yes, I think this makes sense, much clearer. :) But I am a little worried about
whether too many subsequent improvement patches (some of them are quite
small changes) are acceptable.

A long series of small patches, where each patch is cc'd to an appropriate maintainer, will likely get cumulative reviews faster than a single monolithic patch where no one person is the expert on every line touched.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]