[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 3/5] iotests: change qmp_log filters to expec

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4 3/5] iotests: change qmp_log filters to expect QMP objects only
Date: Wed, 19 Dec 2018 13:01:41 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/19/18 5:27 AM, Vladimir Sementsov-Ogievskiy wrote:

But still not sure that it worth it. Isn't it better to just remove fields from 
which are unpredictable, instead of substituting them..

For getting the test to pass when we have a key:unpredictable value in the dict, you are right that both changing it to key:SUBST or removing key work at producing reproducible output. But when it comes to debugging test failure, having key:SUBST in the logs gives you a hint at what else to look at, whereas omitting key altogether may make the reason for the failure completely disappear from the logs.

Thus, I would argue that even though it is more complex to write a filter that can recursively substitute, the resulting output is easier to debug if a test starts failing - and that if the work in doing the more complex filtering has already been submitted and is not too much of a burden to maintain, then we might as well use it rather than going with the simpler case of just eliding the problematic keys or using just textual filtering.

However, I'm not in a good position to argue whether there is a reasonable maintenance burden with the patches in this series, vs. what it would take to rewrite 206 to do just textual filtering instead of QMP dict substitution filtering.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]