[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 09/11] iotests: change qmp_log filters to exp

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v5 09/11] iotests: change qmp_log filters to expect QMP objects only
Date: Wed, 19 Dec 2018 20:53:35 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/19/18 8:29 PM, John Snow wrote:
As laid out in the previous commit's message:

Several places in iotests deal with serializing objects into JSON
strings, but to add pretty-printing it seems desireable to localize


all of those cases.

log() seems like a good candidate for that centralized behavior.
log() can already serialize json objects, but when it does so,
it assumes filters=[] operates on QMP objects, not strings.

qmp_log currently operates by dumping outgoing and incoming QMP
objects into strings and filtering them assuming that filters=[]
are string filters.


Change qmp_log to treat filters as if they're always qmp object filters,
then change the logging call to rely on log()'s ability to serialize QMP
objects, so we're not duplicating that effort.

Add a qmp version of filter_testfiles and adjust the only caller using
it for qmp_log to use the qmp version.

Signed-off-by: John Snow  <address@hidden>
Signed-off-by: John Snow <address@hidden>

Odd double S-o-B differing only by space.

  tests/qemu-iotests/206        |  4 ++--
  tests/qemu-iotests/iotests.py | 24 +++++++++++++++++++++---
  2 files changed, 23 insertions(+), 5 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]