Re: [Qemu-devel] [PATCH for-3.1 2/2] disas/nanomips: Fix format strings

[Stefan Weil]

On 23.12.18 18:10, Aleksandar Markovic wrote:
> Hi, Stefan,
> 
> My plan is to accept this patch plus (in the same patch) following
> changes in nanomips.h:
> 
> This code:
> 
> typedef unsigned short uint16;
> typedef unsigned int uint32;
> typedef long long int64;
> typedef unsigned long long uint64;
> 
> namespace img
> {
>     typedef unsigned long long address;
> }
> 
> should become:
> 
> typedef uint16_t uint16;
> typedef uint32_t uint32;
> typedef int64_t int64;
> typedef uint64_t uint64;
> 
> namespace img
> {
>     typedef uint64_t address;
> }
> 
> The reason is that I would like to keep custom types. The custom types
> names "uint32", "int64", etc. are admittedly too generic, but that
> will change in further development, and it looks do not bother any
> compiler so far. This means that patch 1/1 will not be applied.


I must admit that I don't understand the reason for keeping the custom
types (many software projects work very well with the POSIX types), but
the more important thing is to get the right format strings, and your
approach will work for that.

It's also good that you address the definition of the "address" data
type. Maybe using "typedef uintptr_t address" could also be used
(reducing the memory use for 32 bit systems).

Stefan


> There is no need for respin, I will do the corrections while
> integrating pull request.
> 
> Please let me know if you object over this.
> 
> Thanks again for bringing all these issues!
> 
> Aleksandar