[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX |
Date: |
Mon, 24 Dec 2018 00:49:01 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
Hi Zoltán,
On 12/23/18 9:51 PM, Kővágó, Zoltán wrote:
> There's already a MIN and MAX macro in include/qemu/osdep.h, use them
> instead.
>
> Signed-off-by: Kővágó, Zoltán <address@hidden>
>
> ---
>
> Changes from v1:
> * removed audio_MIN, audio_MAX macros
> ---
[...]>
> diff --git a/audio/audio.h b/audio/audio.h
> index ccfef9e10a..bcbe56d639 100644
> --- a/audio/audio.h
> +++ b/audio/audio.h
> @@ -148,23 +148,6 @@ static inline void *advance (void *p, int incr)
> return (d + incr);
> }
>
> -#ifdef __GNUC__
> -#define audio_MIN(a, b) ( __extension__ ({ \
> - __typeof (a) ta = a; \
> - __typeof (b) tb = b; \
> - ((ta)>(tb)?(tb):(ta)); \
> -}))
> -
> -#define audio_MAX(a, b) ( __extension__ ({ \
> - __typeof (a) ta = a; \
> - __typeof (b) tb = b; \
> - ((ta)<(tb)?(tb):(ta)); \
> -}))
> -#else
> -#define audio_MIN(a, b) ((a)>(b)?(b):(a))
> -#define audio_MAX(a, b) ((a)<(b)?(b):(a))
> -#endif
> -
Those MIN/MAX are smarter than the ones in "qemu/osdep.h", I'd keep them
moving them there.
Regards,
Phil.
- [Qemu-devel] [PATCH v2 18/52] audio: basic support for multi backend audio, (continued)
- [Qemu-devel] [PATCH v2 18/52] audio: basic support for multi backend audio, Kővágó, Zoltán, 2018/12/23
- [Qemu-devel] [PATCH v2 24/52] audio: do not run each backend in audio_run, Kővágó, Zoltán, 2018/12/23
- [Qemu-devel] [PATCH v2 19/52] audio: add audiodev properties to frontends, Kővágó, Zoltán, 2018/12/23
- [Qemu-devel] [PATCH v2 25/52] paaudio: fix playback glitches, Kővágó, Zoltán, 2018/12/23
- [Qemu-devel] [PATCH v2 26/52] audio: remove read and write pcm_ops, Kővágó, Zoltán, 2018/12/23
- [Qemu-devel] [PATCH v2 28/52] audio: api for mixeng code free backends, Kővágó, Zoltán, 2018/12/23
- [Qemu-devel] [PATCH v2 27/52] audio: use size_t where makes sense, Kővágó, Zoltán, 2018/12/23
- [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX, Kővágó, Zoltán, 2018/12/23
- Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX,
Philippe Mathieu-Daudé <=
- Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX, Zoltán Kővágó, 2018/12/23
- Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX, Philippe Mathieu-Daudé, 2018/12/24
- Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX, Kővágó Zoltán, 2018/12/24
- Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX, Philippe Mathieu-Daudé, 2018/12/25
- Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX, Kővágó Zoltán, 2018/12/27
[Qemu-devel] [PATCH v2 36/52] spiceaudio: port to the new audio backend api, Kővágó, Zoltán, 2018/12/23
[Qemu-devel] [PATCH v2 32/52] noaudio: port to the new audio backend api, Kővágó, Zoltán, 2018/12/23
[Qemu-devel] [PATCH v2 31/52] dsoundaudio: port to the new audio backend api, Kővágó, Zoltán, 2018/12/23
[Qemu-devel] [PATCH v2 33/52] ossaudio: port to the new audio backend api, Kővágó, Zoltán, 2018/12/23
[Qemu-devel] [PATCH v2 39/52] audio: unify input and output mixeng buffer management, Kővágó, Zoltán, 2018/12/23