[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [RFC PATCH 1/1] hw/core: add qom getter for kernel-irqchip

From: Wainer dos Santos Moschetta
Subject: [Qemu-devel] [RFC PATCH 1/1] hw/core: add qom getter for kernel-irqchip property
Date: Mon, 24 Dec 2018 06:52:35 -0500

Allows to access the kernel-irqchip property of a Machine
Class object via QOM get method.

Before this patch the property cannot be read although it is
listed by qom-list:

qemu-system-x86_64 -M q35,accel=kvm,kernel-irqchip=split (...)
-> {"execute": "qom-list", "arguments": {"path": "/machine"}}
<- {"return": [{"name": "type", "type": "string"}, (...) , {"name": 
"kernel-irqchip", "type": "on|off|split"} (...)}
-> {"execute": "qom-get", "arguments": {"path": "/machine", "property": 
<- {"error": {"class": "GenericError", "desc": "Insufficient permission to 
perform this operation"}}

It is implemented the machine_get_kernel_irqchip() method,
which evaluates the kernel_irqchip_allowed, *_required, and
*_split fields to determine the value of kernel-irqchip. Note: we
assume there is not inconsistency on the value of those fields.

Then with this change in place, it works as expected:

qemu-system-x86_64 -M q35,accel=kvm,kernel-irqchip=split (...)
-> {"execute": "qom-get", "arguments": {"path": "/machine", "property": 
<- {"return": "split"}

Signed-off-by: Wainer dos Santos Moschetta <address@hidden>
 hw/core/machine.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/hw/core/machine.c b/hw/core/machine.c
index c51423b647..f61003f8f2 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -37,6 +37,21 @@ static void machine_set_accel(Object *obj, const char 
*value, Error **errp)
     ms->accel = g_strdup(value);
+static void machine_get_kernel_irqchip(Object *obj, Visitor *v,
+                                       const char *name, void *opaque,
+                                       Error **errp)
+    MachineState *ms = MACHINE(obj);
+    OnOffSplit mode;
+    if (ms->kernel_irqchip_split) {
+        mode = ON_OFF_SPLIT_SPLIT;
+    } else {
+        mode = (ms->kernel_irqchip_allowed && ms->kernel_irqchip_required) ?
+                ON_OFF_SPLIT_ON : ON_OFF_SPLIT_OFF;
+    }
+    visit_type_OnOffSplit(v, name, &mode, errp);
 static void machine_set_kernel_irqchip(Object *obj, Visitor *v,
                                        const char *name, void *opaque,
                                        Error **errp)
@@ -540,7 +555,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
         "Accelerator list", &error_abort);
     object_class_property_add(oc, "kernel-irqchip", "on|off|split",
-        NULL, machine_set_kernel_irqchip,
+        machine_get_kernel_irqchip, machine_set_kernel_irqchip,
         NULL, NULL, &error_abort);
     object_class_property_set_description(oc, "kernel-irqchip",
         "Configure KVM in-kernel irqchip", &error_abort);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]