[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdi
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir() |
Date: |
Thu, 3 Jan 2019 14:45:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/3/19 2:31 PM, Li Qiang wrote:
> Spotted by Coverity: CID 1397070
Closing a CVE to open a CID :)
Fixes: bab9df35ce
>
> Signed-off-by: Li Qiang <address@hidden>
> ---
> hw/usb/dev-mtp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index b19b576278..666bafd9e8 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev-mtp.c
> @@ -666,6 +666,7 @@ static void usb_mtp_object_readdir(MTPState *s, MTPObject
> *o)
> }
> dir = fdopendir(fd);
> if (!dir) {
> + close(fd);
> return;
This or:
goto cleanup_fd;
> }
> #ifdef CONFIG_INOTIFY1
> @@ -682,6 +683,7 @@ static void usb_mtp_object_readdir(MTPState *s, MTPObject
> *o)
> usb_mtp_add_child(s, o, entry->d_name);
> }
> closedir(dir);
And:
cleanup_fd:
> + close(fd);
> }
>
> /* ----------------------------------------------------------------------- */
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>