[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevi
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s |
Date: |
Fri, 4 Jan 2019 16:31:24 +0000 |
User-agent: |
Mutt/1.11.1 (2018-12-01) |
Almost done, there is one thing left which I believe is an issue.
Whenever I attach a raw file to QEMU, it print:
qemu-system-i386: warning: Opening a block device as a file using the
'file' driver is deprecated
So, I think the comment below isn't true. We should create a "raw"
driver for "raw" files.
On Thu, Dec 20, 2018 at 05:14:37PM +0000, Paul Durrant wrote:
> +static XenBlockDrive *xen_block_drive_create(const char *id,
> + const char *device_type,
> + QDict *opts, Error **errp)
> +{
...
> + if (params) {
> + char **v = g_strsplit(params, ":", 2);
> +
> + if (v[1] == NULL) {
> + filename = g_strdup(v[0]);
> + driver = g_strdup("file");
> + } else {
> + if (strcmp(v[0], "aio") == 0) {
> + driver = g_strdup("file");
> + } else if (strcmp(v[0], "vhd") == 0) {
> + driver = g_strdup("vpc");
> + } else {
> + driver = g_strdup(v[0]);
> + }
> + filename = g_strdup(v[1]);
> + }
> +
> + g_strfreev(v);
> + }
> +
...
> + /* If the image is a raw file then we are done */
raw files should use the "raw" driver, so we aren't done yet.
> + if (!strcmp(driver, "file")) {
> + goto done;
> + }
--
Anthony PERARD
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Paul Durrant, 2019/01/04
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s,
Anthony PERARD <=
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Paul Durrant, 2019/01/04
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Kevin Wolf, 2019/01/08
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Paul Durrant, 2019/01/08
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Anthony PERARD, 2019/01/08
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Paul Durrant, 2019/01/08
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Paul Durrant, 2019/01/08
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Kevin Wolf, 2019/01/08
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Paul Durrant, 2019/01/08
- Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s, Anthony PERARD, 2019/01/08