[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/8] nbd: publish _lookup functions
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PULL 1/8] nbd: publish _lookup functions |
Date: |
Sat, 5 Jan 2019 08:00:53 -0600 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
These functions are used for formatting pretty trace points. We are
going to add some in block/nbd-client, so, let's publish all these
functions at once. Note, that nbd_reply_type_lookup is already
published, and constants, "named" by these functions live in
include/block/nbd.h too.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
---
include/block/nbd.h | 5 +++++
nbd/nbd-internal.h | 5 -----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/block/nbd.h b/include/block/nbd.h
index 6a5bfe5d559..65402d33964 100644
--- a/include/block/nbd.h
+++ b/include/block/nbd.h
@@ -343,5 +343,10 @@ static inline bool nbd_reply_is_structured(NBDReply *reply)
}
const char *nbd_reply_type_lookup(uint16_t type);
+const char *nbd_opt_lookup(uint32_t opt);
+const char *nbd_rep_lookup(uint32_t rep);
+const char *nbd_info_lookup(uint16_t info);
+const char *nbd_cmd_lookup(uint16_t info);
+const char *nbd_err_lookup(int err);
#endif
diff --git a/nbd/nbd-internal.h b/nbd/nbd-internal.h
index eeff78d3c98..f38be9ebaaf 100644
--- a/nbd/nbd-internal.h
+++ b/nbd/nbd-internal.h
@@ -100,11 +100,6 @@ struct NBDTLSHandshakeData {
void nbd_tls_handshake(QIOTask *task,
void *opaque);
-const char *nbd_opt_lookup(uint32_t opt);
-const char *nbd_rep_lookup(uint32_t rep);
-const char *nbd_info_lookup(uint16_t info);
-const char *nbd_cmd_lookup(uint16_t info);
-const char *nbd_err_lookup(int err);
int nbd_drop(QIOChannel *ioc, size_t size, Error **errp);
--
2.20.1
- [Qemu-devel] [PULL 0/8] NBD patches through 2019-01-05, Eric Blake, 2019/01/05
- [Qemu-devel] [PULL 1/8] nbd: publish _lookup functions,
Eric Blake <=
- [Qemu-devel] [PULL 2/8] nbd/client: Trace all server option error messages, Eric Blake, 2019/01/05
- [Qemu-devel] [PULL 4/8] qemu-nbd: Use program name in error messages, Eric Blake, 2019/01/05
- [Qemu-devel] [PULL 5/8] nbd: Document timeline of various features, Eric Blake, 2019/01/05
- [Qemu-devel] [PULL 3/8] block/nbd-client: use traces instead of noisy error_report_err, Eric Blake, 2019/01/05
- [Qemu-devel] [PULL 8/8] nbd/client: Drop pointless buf variable, Eric Blake, 2019/01/05
- [Qemu-devel] [PULL 6/8] nbd/client: More consistent error messages, Eric Blake, 2019/01/05
- [Qemu-devel] [PULL 7/8] qemu-nbd: Fail earlier for -c/-d on non-linux, Eric Blake, 2019/01/05
- Re: [Qemu-devel] [PULL 0/8] NBD patches through 2019-01-05, Peter Maydell, 2019/01/07