qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-4.0 v4 2/4] refactor load_image_size


From: Li Zhijian
Subject: Re: [Qemu-devel] [PATCH for-4.0 v4 2/4] refactor load_image_size
Date: Tue, 8 Jan 2019 09:09:56 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1


On 1/7/19 18:33, Stefano Garzarella wrote:
On Mon, Dec 24, 2018 at 3:16 AM Li Zhijian <address@hidden> wrote:

On 12/22/18 00:12, Michael S. Tsirkin wrote:
On Thu, Dec 06, 2018 at 10:32:11AM +0800, Li Zhijian wrote:
Don't expect read(2) can always read as many as it's told.

Signed-off-by: Li Zhijian <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
This is more a theoretical bugfix than a refactoring right?
Yes, it does.

how about change the title to : "enhance reading on load_image_size()" or such
Maybe something like this: "hw/core/loader.c: Read as long as possible
in load_image_size()"

It really helps, i will take your suggestion to the subject.

Thanks
Zhijian





Reviewed-by: Stefano Garzarella <address@hidden>






reply via email to

[Prev in Thread] Current Thread [Next in Thread]