[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 20/25] hyperv: express dependencies with kco
From: |
Yang Zhong |
Subject: |
Re: [Qemu-devel] [RFC PATCH 20/25] hyperv: express dependencies with kconfig |
Date: |
Tue, 8 Jan 2019 18:35:47 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jan 04, 2019 at 04:38:34PM +0100, Thomas Huth wrote:
> On 2018-12-27 07:34, Yang Zhong wrote:
> > remove default-configs/hyperv.mak and make dependencies
> > with Kconfig.
> >
> > Signed-off-by: Yang Zhong <address@hidden>
> > ---
> > default-configs/hyperv.mak | 2 --
> > default-configs/i386-softmmu.mak | 1 -
> > hw/hyperv/Kconfig | 1 +
> > hw/i386/Kconfig | 2 ++
> > 4 files changed, 3 insertions(+), 3 deletions(-)
> > delete mode 100644 default-configs/hyperv.mak
> >
[...]
> > diff --git a/hw/hyperv/Kconfig b/hw/hyperv/Kconfig
> > index be724b7f8b..632c3a675b 100644
> > --- a/hw/hyperv/Kconfig
> > +++ b/hw/hyperv/Kconfig
> > @@ -1,5 +1,6 @@
> > config HYPERV
> > bool
> > + depends on KVM
> >
> > config HYPERV_TESTDEV
> > bool
>
> Should HYPERV_TESTDEV maybe get a "depends on HYPERV", too?
>
Thomas, thanks, i will change it.
Regards,
Yang
> > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> > index 695a67f88d..af4b81bae1 100644
> > --- a/hw/i386/Kconfig
> > +++ b/hw/i386/Kconfig
> > @@ -11,6 +11,8 @@ config PC
> > select I8257
> > select MC146818RTC
> > select TPM_TIS if TPM
> > + select HYPERV
> > + select HYPERV_TESTDEV
> >
> > config PC_PCI
> > bool
> >
>
> Reviewed-by: Thomas Huth <address@hidden>